stackswitcher: Don't do unneeded update
authorBenjamin Otte <otte@redhat.com>
Tue, 18 Feb 2014 12:56:26 +0000 (13:56 +0100)
committerBenjamin Otte <otte@redhat.com>
Thu, 20 Feb 2014 01:10:07 +0000 (02:10 +0100)
The update of the needs-attention state is done via its own property,
so it doesn't need to be done via visibility changes.

This patch is largely the result of inspecting the code due to a warning
and not a result of testing. So if issues pop up that bisect back to
this patch, that's why.

gtk/gtkstackswitcher.c

index 83e2eed194a7c5336df98487ce7288aca39341da..361bd54bc07e340042a5545b465530ff67393d35 100644 (file)
@@ -310,10 +310,6 @@ on_child_changed (GtkWidget        *widget,
       gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (button), TRUE);
       priv->in_child_changed = FALSE;
     }
-
-  g_hash_table_foreach (priv->buttons,
-                        (GHFunc)update_needs_attention,
-                        priv->stack);
 }
 
 static void